amarillo/amarillo-core
5
0
Fork 0
Code Issues 17 Pull requests Packages Projects Releases Wiki Activity

Enhance missing trips #24

New issue
Open
opened 2025-01-28 11:08:49 +01:00 by Csaba · 3 comments
Csaba commented 2025-01-28 11:08:49 +01:00
Owner
Copy link
  • Delete enhanced trips from sampledata
  • On startup enhance missing trips
  • Enhance outdated trips
- [x] Delete enhanced trips from sampledata - [x] On startup enhance missing trips - [x] Enhance outdated trips
Csaba self-assigned this 2025-01-28 11:08:49 +01:00
Csaba added this to the Amarillo project 2025-01-28 11:08:49 +01:00
Csaba commented 2025-01-28 13:07:19 +01:00
Author
Owner
Copy link

I see problem: if there are trips that need to be enhanced, since the 3 services are started at the same time, the initial GTFS generation will miss them. This is a race condition between amarillo and generator.

I see problem: if there are trips that need to be enhanced, since the 3 services are started at the same time, the initial GTFS generation will miss them. This is a race condition between amarillo and generator.
Csaba commented 2025-01-29 11:04:09 +01:00
Author
Owner
Copy link

I have the code to enhance missing/updated trips on startup
63edfc2734
475b224462

I see problem: if there are trips that need to be enhanced, since the 3 services are started at the same time, the initial GTFS generation will miss them. This is a race condition between amarillo and generator.

Confirmed, this happens very easily
image

Possible solution: generator should not create GTFS immediately on startup, but wait for a /export call that is sent out by amarillo-core when all is ready

I have the code to enhance missing/updated trips on startup https://github.com/mfdz/amarillo/pull/34/commits/63edfc2734e1f3e8a79cdca514479a4e3148baa7 https://github.com/mfdz/amarillo/pull/34/commits/475b224462f0844d7d4767ce5c490c3f3e45ed72 > I see problem: if there are trips that need to be enhanced, since the 3 services are started at the same time, the initial GTFS generation will miss them. This is a race condition between amarillo and generator. Confirmed, this happens very easily <img width="1383" alt="image" src="/attachments/bab2c266-4bbc-417e-8b04-2a135fb42d7f"> Possible solution: generator should not create GTFS immediately on startup, but wait for a /export call that is sent out by amarillo-core when all is ready
image.png
220 KiB
Csaba commented 2025-01-29 11:10:28 +01:00
Author
Owner
Copy link

Possible solution #2: control startup dependencies using docker compose
https://docs.docker.com/compose/how-tos/startup-order/
I think it is better doing it this way, as this can also solve many more similar issues that might come up.
E.g if stops loading is too slow, enhancements on startup can time out (I have not seen this happen yet)

Possible solution #2: control startup dependencies using docker compose https://docs.docker.com/compose/how-tos/startup-order/ I think it is better doing it this way, as this can also solve many more similar issues that might come up. E.g if stops loading is too slow, enhancements on startup can time out (I have not seen this happen yet)
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
dev
fastapi-enhancer
permissions
carpool-events
bearer-token
log-errors
grfs-export
docker-build-test
static-files
jenkins-test
No results found.
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Amarillo
Assignees
Clear assignees
No assignees
Csaba
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: amarillo/amarillo-core#24
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?